Repository navigation
tape: captions last per word, playback speed divides time - #727
Merged
Merged
Conversation
A caption stays up 0.3 s a word of title and text at 1x, never under 2 s (Script.reading_ms_per_word, reading_min_ms), so long captions no longer vanish quickly. The player's rate becomes Sequencer.speed, a plain f32 in 0.5..4 (default 1) stepped through 0.5, 0.75, 1, 1.5, 2, 3, 4; it divides demo time on the wall clock (playUntil, wallMs). Seek and rewind ask advance for a demo time, so they stay exact at any speed. Part of fizzyedit/work#16 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lc78nzw65EqAttcHSvg2XF
foxnne
force-pushed
the
automation/caption-time
branch
from
October 21, 2026 18:58
11bf60a to
bf72b84
Compare
foxnne
marked this pull request as ready for review
October 21, 2026 19:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of fizzyedit/work#16
What changes
Script.reading_ms_per_word(300 ms) per word of title and text at 1x, betweenScript.reading_min_ms(2 s) andScript.reading_max_ms(12 s, the old ceiling, kept). All three are named constants. The old character-count formula is gone, so long captions no longer vanish quickly.Player.rateintoSequencer.speed: a plainf32, default 1, clamped to 0.5..4 (setSpeed), stepped throughSequencer.speeds= 0.5, 0.75, 1, 1.5, 2, 3, 4 (stepSpeed).playUntilturns a frame's wall time into demo time. A caption'smsis demo time too, so captions and the demo speed up together with no separate conversion.advancefor a demo time, which no speed enters, so they stay exact at any speed.Player.rate/setRate/stepRateare replaced byplayer.seq.speed/setSpeed/stepSpeed; the overlay,Editor.zigand thedemo.speedcommand follow. No UI added; the slider is a later PR.docs/AUTOMATION.mddescribes both.Verification (Linux cloud)
playUntil; clamping and stepping; a rewind and replay lands on the same moment at every speed.scripts/check-fmt.sh,scripts/zb build,build test,build test-integration(92/92 steps succeeded),build check-web,build test-sdk-version,build lint,build check-tests-reachedall pass.seq.speed.sdk_versionuntouched.Generated by Claude Code
Review fixes:
reading_max_ms, the old ceiling), with a test.Sequencer.wallMsis removed: a caption'smsis demo time and playback speed advances demo time, so captions already scale with no conversion. docs/AUTOMATION.md says so.demo.speedcommand'sratestill accepts 0 to 4; values between 0 and 0.5 clamp to 0.5, now stated in its description.